Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Fix beam search accuracy/functional errors #27833

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

sshlyapn
Copy link
Contributor

Details:

  • Fixed "error set arg" error caused by not initialized internal memory buffers required for indirect sdpa_opt kernel in case of micro_sdpa + sdpa_opt
  • Fixed beam_table offset in shape_info
  • Fixed beam table index calculation in rearrange_cache() call considering concat_axis

@sshlyapn sshlyapn added category: GPU OpenVINO GPU plugin Code Freeze backport label to backport PR to the release branch labels Nov 29, 2024
@sshlyapn sshlyapn added this to the 2025.0 milestone Nov 29, 2024
@sshlyapn sshlyapn requested review from a team as code owners November 29, 2024 16:00
@p-durandin p-durandin enabled auto-merge December 4, 2024 07:02
@p-durandin p-durandin added this pull request to the merge queue Dec 4, 2024
@p-durandin p-durandin removed this pull request from the merge queue due to a manual request Dec 4, 2024
@p-durandin p-durandin added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 4, 2024
@p-durandin p-durandin added this pull request to the merge queue Dec 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2024
### Details:
- Fixed "error set arg" error caused by not initialized internal memory
buffers required for indirect sdpa_opt kernel in case of micro_sdpa +
sdpa_opt
 - Fixed beam_table offset in shape_info
- Fixed beam table index calculation in rearrange_cache() call
considering concat_axis
 - Backport of #27833

---------

Co-authored-by: Pavel Durandin <[email protected]>
Merged via the queue into openvinotoolkit:master with commit c69e5d7 Dec 4, 2024
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport label to backport PR to the release branch category: GPU OpenVINO GPU plugin Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants